Skip to content

[Backport 5.1.x] Fix dynamic version resolution in pyproject.toml#14396

Merged
giohappy merged 1 commit into
5.1.xfrom
backport-14395-to-5.1.x
Jun 29, 2026
Merged

[Backport 5.1.x] Fix dynamic version resolution in pyproject.toml#14396
giohappy merged 1 commit into
5.1.xfrom
backport-14395-to-5.1.x

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Backport a2dda2e from #14395.

setuptools resolves the dynamic version attr by reading geonode.__version__
directly. That attribute is a tuple (e.g. (5, 1, 0, 'final', 0)); setuptools
normalises a non-string attr by joining it with dots, producing an invalid
PEP 440 version like '5.1.0.final.0' and breaking the wheel build.

Expose a plain string attribute __version_str__ = get_version() in
geonode/__init__.py and point the dynamic version at it, so setuptools reads
an already-normalised version string (e.g. '5.1.0').

(cherry picked from commit a2dda2e)
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 29, 2026
@giohappy giohappy self-requested a review June 29, 2026 15:39
@giohappy giohappy merged commit ed36af4 into 5.1.x Jun 29, 2026
3 checks passed
@giohappy giohappy deleted the backport-14395-to-5.1.x branch June 29, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant